[Bug 228490] Review Request: hunspell-nl - Dutch hunspell dictionaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-nl - Dutch hunspell dictionaries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228490


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776                      |163779
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-13 19:25 EST -------
upstreamid is wrong, should be 20-Jul-2005 (archive date) or 17/19-Jul-2005
(files' date)



GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 
9f5432aeb20ab7e9a3c72877b71056a33b2bd9ba  nl_NL.zip
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license GPL stated in the tag is the same as the web site and the included
documentation say; it is not included in the package because upstream did not
include it either
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED but please fix the version before uploading to CVS; you should also ask
upstream to include the GPL license in the archive

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.