[Bug 228293] Review Request: gkrellm-moon - Moon clock plugin for GKrellM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-moon - Moon clock plugin for GKrellM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228293


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2007-02-13 23:05 EST -------
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
0e30da51526d68cbce146ea2bdd9b685  gkrellmoon-0.6.tar.gz
0e30da51526d68cbce146ea2bdd9b685  gkrellmoon-0.6.tar.gz.1
OK - BuildRequires correct
See below - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Default permissions are:
%defattr(-, root, root, 0755)
Is that needed, or can it be changed to:
%defattr(-, root, root, -)

2. Can you please use the one true build root(tm):

      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.