[Bug 199592] Review Request: icu4j

Wed Feb 14 05:55:27 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: icu4j

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199592

mwringe at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|mwringe at redhat.com          |vivekl at redhat.com

------- Additional Comments From mwringe at redhat.com  2007-02-14 00:55 EST -------
(In reply to comment #20)
> ...
>  - for non-numerics (pre-release, CVS snapshots, etc.), see
>    http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PackageRelease
>    . 0:3.4.5-2jpp.1 -> 0:3.4.5-2jpp.2%{?dist} to be inline with 
>      http://fedoraproject.org/wiki/PackagingDrafts/ExceptionJPackage
Done

>  ...
> X * license field matches the actual license.
>    + The license according
>      http://www-306.ibm.com/software/globalization/icu/license.jsp is X License
Yeah, the X License = X.net License = X11 License = MIT License
Only the MIT license and the X.net License appear in the offical rpmlint
license list. Should this be called what the project calls it "X license"
or should the MIT license be used instead since rpmlint likes it better?

> ...
> X correct buildroot
>  - should be:
>    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>    . Use the buildroot specified above
Fixed

> X * if %{?dist} is used, it should be in that form (note the ? and %
> locations)
>   . Use the new naming convention mentioned above
Fixed

> ...
> X rpmlint on <this package>.srpm and rpm gives no output
> W: icu4j non-standard-group Development/Libraries/Java
- group warnings can be ignored
> W: icu4j wrong-file-end-of-line-encoding
- fixed
> W: icu4j wrong-file-end-of-line-encoding
- fixed
> W: icu4j wrong-file-end-of-line-encoding
- fixed
> W: icu4j-eclipse non-standard-group Text Editors/Integrated Development
> Environments (IDE)
- group warnings can be ignored
> W: icu4j-eclipse no-documentation
>  . There should probably be an EPL file in the eclipse subpackage that needs
>    to be added
The plugin should be under the X license since this is the license of the
project. This has now been added

> W: icu4j-javadoc non-standard-group Development/Documentation
- can ignore group warnings
> W: icu4j-javadoc dangerous-command-in-%post rm
- fixed
> W: icu4j non-standard-group Development/Libraries/Java
- can ignore group warnings
> W: icu4j mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 55)
- fixed

> ...
> X use macros appropriately and consistently
>  - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
>  - $RPM_BUILD_ROOT and %{buildroot} used interchangably
fixed

> ...
> X consider using cp -p to preserve timestamps
>   Some cp commands not using -p option, suggest adding them if possible
fixed

>...
> X package should own all directories and files
>   . /usr/lib/eclipse should be owned by libswt3-gtk2 in the latest update to it,
> add a require for it
>   . jpackage-utils is needed for the javadoc and base package since it needs
> /usr/share/java{,doc}.
>     Please take a look at
> https://zarb.org/pipermail/jpackage-discuss/2007-February/011119.html and
>     modify the javadoc handling appropriately. If you use the above javadoc
> handling then you can 
>     limit to Requires: jpackage-utils in both javadoc and main packages, o/w you
> need Requires(post)
>     and Requires on jpackage-utils as well as Requires(post) on rm and ln in
> javadoc package and a 
>     requires on the main package for jpackage-utils
added requires on jpackage-utils and the libecj3-gtk to proper packages

> ...
> X verify the final provides and requires of the binary RPMs
>   + Builds in mock fine
>   . Requires need to be fixed, check "package should own all directories and
files"
> 
> SHOULD:
> * package should include license text in the package and mark it with %doc
>   + OK
> * package should build on i386
>   + Builds in mock
> * package should build in mock
>   + OK
> 
> 

RPMLINT on new packages:

srpm:
rpmlint icu4j-3.4.5-2jpp.1.fc7.src.rpm
W: icu4j non-standard-group Development/Libraries/Java

rpms:
E: icu4j explicit-lib-dependency libswt3-gtk2
- I believe this error is only occuring because it has 'lib' in the name.
This package is needed to build the eclipse plugin subpackage.

W: icu4j non-standard-group Development/Libraries/Java
W: icu4j-eclipse non-standard-group Text Editors/Integrated Development
Environments (IDE)
W: icu4j-javadoc non-standard-group Development/Documentation

The updated packages can be found here:
https://mwringe.108.redhat.com/files/documents/175/215/icu4j-3.4.5-2jpp.1.fc7.src.rpm
https://mwringe.108.redhat.com/files/documents/175/216/icu4j-3.4.5-2jpp.1.fc7.i386.rpm
https://mwringe.108.redhat.com/files/documents/175/217/icu4j-debuginfo-3.4.5-2jpp.1.fc7.i386.rpm
https://mwringe.108.redhat.com/files/documents/175/218/icu4j-eclipse-3.4.5-2jpp.1.fc7.i386.rpm
https://mwringe.108.redhat.com/files/documents/175/219/icu4j-javadoc-3.4.5-2jpp.1.fc7.i386.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.