[Bug 228492] Review Request: hunspell-nn - Nynorsk hunspell dictionaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-nn - Nynorsk hunspell dictionaries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228492


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776                      |163779
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-14 03:59 EST -------
Minor: upstreamid does not seem correct, web site says
nn_NO.zip                08-May-2006
Original upstream URL seems to be http://spell-norwegian.alioth.debian.org/

GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 
84b4a34ae81517d08bfa69b19f1372240c0a021c  nn_NO.zip
(see also comment #1 below)
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that it includes only 3 text files)
- the license ( GPL ) stated in the tag is the same as the web site and the
included doc say; it is not included in the package because upstream did not
include it either
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED
as usual, please ask upstream to include the license file in the archive

COMMENT: upstream seems to offer a newer version
(http://alioth.debian.org/frs/download.php/1600/no_NO-pack-2.0.8.zip, 30 may
2006) but it contains exactly the same files as those submitted by Caolan


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.