[Bug 227050] Review Request: dtdparser-1.21-3jpp - A Java DTD Parser

Wed Feb 14 15:50:14 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dtdparser-1.21-3jpp - A Java DTD Parser

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227050

tbento at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tbento at redhat.com           |vivekl at redhat.com

------- Additional Comments From tbento at redhat.com  2007-02-14 10:50 EST -------
> X * package is named appropriately
>    . 0:3.4.5-2jpp.1 -> 0:3.4.5-2jpp.2%{?dist} to be inline with 
>      http://fedoraproject.org/wiki/PackagingDrafts/ExceptionJPackage

Fixed.

> X correct buildroot
>  - should be:
>    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Fixed.

> X if %{?dist} is used, it should be in that form (note the ? and %
> locations)
>   . See above about naming convention

Fixed

> X* rpmlint on <this package>.srpm and rpms gives no output
>  - justify warnings if you think they shouldn't be there
> W: dtdparser non-standard-group Development/Libraries/Java
> The value of the Group tag in the package is not valid.  Valid groups are:
> "Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
> "Applications/Communications", "Applications/Databases",
> "Applications/Editors", "Applications/Emulators", "Applications/Engineering",
> "Applications/File", "Applications/Internet", "Applications/Multimedia",
> "Applications/Productivity", "Applications/Publishing", "Applications/System",
> "Applications/Text", "Development/Debug", "Development/Debuggers",
> "Development/Languages", "Development/Libraries", "Development/System",
> "Development/Tools", "Documentation", "System Environment/Base", "System
> Environment/Daemons", "System Environment/Kernel", "System
> Environment/Libraries", "System Environment/Shells", "User
> Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

This warning can be ignored.

>  E: dtdparser tag-not-utf8 %changelog
> The character encoding of the value of this tag is not UTF-8.
> . use iconv to convert to UTF8

Fixed.

> E: dtdparser non-utf8-spec-file dtdparser.spec
> The character encoding of the spec file is not UTF-8.  Convert it for
> example using iconv(1).
> . use iconv to convert to UTF8

Fixed.

> W: dtdparser mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 36)
> The specfile mixes use of spaces and tabs for indentation, which is a
> cosmetic annoyance.  Use either spaces or tabs for indentation, not both.
> . Replace the tabs with spaces (:set tabexpand :%retab in vim)

Fixed.

> W: dtdparser non-standard-group Development/Libraries/Java
> The value of the Group tag in the package is not valid.  Valid groups are:
> "Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
> "Applications/Communications", "Applications/Databases",
> "Applications/Editors", "Applications/Emulators", "Applications/Engineering",
> "Applications/File", "Applications/Internet", "Applications/Multimedia",
> "Applications/Productivity", "Applications/Publishing", "Applications/System",
> "Applications/Text", "Development/Debug", "Development/Debuggers",
> "Development/Languages", "Development/Libraries", "Development/System",
> "Development/Tools", "Documentation", "System Environment/Base", "System
> Environment/Daemons", "System Environment/Kernel", "System
> Environment/Libraries", "System Environment/Shells", "User
> Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

This warning can be ignored.

> E: dtdparser tag-not-utf8 %changelog
> The character encoding of the value of this tag is not UTF-8.
> . use iconv to convert to UTF8

Fixed.

> W: dtdparser-javadoc non-standard-group Development/Documentation
> The value of the Group tag in the package is not valid.  Valid groups are:
> "Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
> "Applications/Communications", "Applications/Databases",
> "Applications/Editors", "Applications/Emulators", "Applications/Engineering",
> "Applications/File", "Applications/Internet", "Applications/Multimedia",
> "Applications/Productivity", "Applications/Publishing", "Applications/System",
> "Applications/Text", "Development/Debug", "Development/Debuggers",
> "Development/Languages", "Development/Libraries", "Development/System",
> "Development/Tools", "Documentation", "System Environment/Base", "System
> Environment/Daemons", "System Environment/Kernel", "System
> Environment/Libraries", "System Environment/Shells", "User
> Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

This warning can be ignored.

> E: dtdparser-javadoc tag-not-utf8 %changelog
> The character encoding of the value of this tag is not UTF-8.
> . use iconv to convert to UTF8

Fixed.

> E: dtdparser-javadoc zero-length
> /usr/share/javadoc/dtdparser-1.21/package-list
>  + I checked the build root on a local build and this seems to be created by
>    the javadoc task in ant. This can probably be ignored?

This warning can be ignored because the file is automated and thus, changing on
a daily basis.

> X make sure lines are <= 80 characters
>   . minor fixes needed

Fixed.

> X make a -doc sub-package if necessary
>   Standardize the javadoc package handling around
>   https://zarb.org/pipermail/jpackage-discuss/2007-February/011119.html
>  - see
>   
>http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b

Fixed.

> X* package should own all directories and files
>  + Use jpackage-utils in Requires(x), Requires since installing to
> %{_javadir}/%{_javadocdir} 

Fixed.

> X* %doc files should not affect runtime
>   . javadoc should use %doc for its files

Fixed.

> X* verify the final provides and requires of the binary RPM
> rpm -qp --provides ../RPMS/noarch/dtdparser-*
> dtdparser = 0:1.21-3jpp
> dtdparser-javadoc = 0:1.21-3jpp
> rpm -qp --requires ../RPMS/noarch/dtdparser-*
> rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>  . Requires needs jpakage-utils as mentioned earlier
>  . Should have a requires on java?

Fixed. 

The src rpm can be found at this link:
http://tequila-sunrise.ath.cx/rpmreviews/F7/dtdparser/dtdparser-1.21-3jpp.1.src.rpm

Let me know if there's anything else I need to fix or forgot to fix.  
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.