[Bug 227069] Review Request: jaxen-bootstrap-1.1-0.b7.3jpp - A convenience package for build of dom4j

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jaxen-bootstrap-1.1-0.b7.3jpp - A convenience package for build of dom4j


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227069





------- Additional Comments From overholt at redhat.com  2007-02-14 12:40 EST -------
Created an attachment (id=148075)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=148075&action=view)
patch for 1.1b7 to clear up issues

> X package is named appropriately
>  . release should be of the form 0.Z.tag.Xjpp.Y%{?dist}

Fixed.	rpmvercmp used to verify that epoch bump not necessary.

> X license field matches the actual license.
>  . according to their website, it's Apache-style

Fixed.

> X specfile name matches %{name}
>  . specfile should be jaxen-bootstrap.spec

Yup.

> X verify source and patches
>  . where do the xsl and xml files come from?
>  . we should note why dom4j is needed

Notes added.  I can't find the source upstream anymore so I don't know how to
verify the md5sums :(

> X correct buildroot
>  - should be:
>    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Fixed.

> X %{?dist} needs to be added

Fixed.

> X license text included in package and marked with %doc

Fixed.

> * packages meets FHS (http://www.pathname.com/fhs/)
> W: jaxen-bootstrap invalid-license Open Source
> 
> X fix this

Fixed.

> W: jaxen-bootstrap unversioned-explicit-provides jaxen-bootstrap
> 
> . I think this is an unnecessary provide

Removed.

> W: jaxen-bootstrap rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
> 
> . get rid of the rm -rf line at the beginning of prep ...

Done.

> E: jaxen-bootstrap no-cleaning-of-buildroot %install
> 
> ... and add it to the beginning of %install

Fixed.

> W: jaxen-bootstrap mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line
37)
> 
> X fix this (emacs M-x untabify)

Done.

> X Vendor tag should not be used
> X Distribution tag should not be used

Fixed, fixed.

> ? consider using cp -p to preserve timestamps (%prep line 4

Unnecessary as it's only used for bootstrap building.

> X final provides and requires of the binary RPMs
>  . remove unnecessary Provides: %{name}?

Done.

I still can't build, but I think other than the that the source can't be found,
everything is taken care of by this patch.  Except perhaps changing the licence
to BSD which is what I think it actually is.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.