[Bug 226479] Merge Review: tcl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tcl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226479





------- Additional Comments From wart at kobold.org  2007-02-15 15:04 EST -------
(In reply to comment #9)
> > E: tcl invalid-soname /usr/lib/libtcl8.4.so libtcl8.4.so
> It must stay for backward compatibility.
> 
> > Use %{_libdir} instead of %{_prefix}/%{_lib}
> Please see if it's everything allright.

The use of %{_libdir} looks ok, but the backwards-compatible link is still wrong:

cd %{_datadir}
ln -s %{name}%{majorver} $RPM_BUILD_ROOT/%{_libdir}/%{name}%{majorver}

This creates the same recursive link:
lrwxrwxrwx 1 root root 6 2007-02-15 11:47 /usr/lib/tcl8.4 -> tcl8.4

I think you want either:
ln -s %{_datadir}/%{name}%{majorver} $RPM_BUILD_ROOT/%{_libdir}/%{name}%{majorver}

or 

ln -s %{_datadir}/%{name}%{majorver}
$RPM_BUILD_ROOT/%{_prefix}/lib/%{name}%{majorver}

It's unclear to me from the comment in the spec file if this should be
%{_prefix}/lib or %{_libdir} for backwards compatibility.  Do you know which
other packages need this backwards compatible link?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.