[Bug 226273] Merge Review: perl-Net-Telnet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-Net-Telnet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226273





------- Additional Comments From mastahnke at gmail.com  2007-02-15 22:59 EST -------
 OK - Package meets naming and packaging guidelines
 OK - Spec file matches base package name.
 OK - Spec has consistant macro usage.
 OK - Meets Packaging Guidelines.
 OK - Spec in American English
 OK - Spec is legible.
 OK - Sources match upstream md5sum:

 OK - BuildRequires correct
 OK  - Package has %defattr and permissions on files is good.
 OK - Package has a correct %clean section.
 OK - Package has correct buildroot
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 OK - Package is code or permissible content.
 OK  - Packages %doc files don't affect runtime.
 OK - Package compiles and builds on at least one arch.
 OK - Package has no duplicate files in %files.
 OK - Package doesn't own any directories other packages own.
 OK - Package owns all the directories it creates.
 OK - Should build in mock.
 OK - Should build on all supported archs
 OK - Should function as described.
 OK - Should have sane scriptlets.
 OK  - Should package latest version
 OK - check for outstanding bugs on package. (For core merge reviews)


Issues:
XX -- License is GPL or Artistic, not sure if that is valid.
XX -- License (GPL or Artistic) Not include in package (%doc area)
XX -- Should have dist tag
XX -- MANIFEST shouldn't be included in Perl modules. 
[builder at rawhide noarch]$ rpmlint perl-Net-Telnet-3.03-5.noarch.rpm
E: perl-Net-Telnet description-line-too-long Net::Telnet allows you to make
client connections to a TCP port and do network I/O,
E: perl-Net-Telnet description-line-too-long especially to a port using the
TELNET protocol. Simple I/O methods such as print,
E: perl-Net-Telnet description-line-too-long get, and getline are provided. More
sophisticated interactive features are provided
E: perl-Net-Telnet description-line-too-long because connecting to a TELNET port
ultimately means communicating with a program
E: perl-Net-Telnet description-line-too-long designed for human interaction.
These interactive features include the ability to
E: perl-Net-Telnet description-line-too-long specify a time-out and to wait for
patterns to appear in the input stream, such as
W: perl-Net-Telnet manifest-in-perl-module
/usr/share/doc/perl-Net-Telnet-3.03/MANIFEST
[builder at rawhide noarch]$


[builder at rawhide SRPMS]$ rpmlint -I manifest-in-perl-module
manifest-in-perl-module :
This perl module package contains a MANIFEST or a MANIFEST.SKIP file
in the documentation directory.

[builder at rawhide SRPMS]$ rpmlint perl-Net-Telnet-3.03-5.src.rpm
E: perl-Net-Telnet description-line-too-long Net::Telnet allows you to make
client connections to a TCP port and do network I/O,
E: perl-Net-Telnet description-line-too-long especially to a port using the
TELNET protocol. Simple I/O methods such as print,
E: perl-Net-Telnet description-line-too-long get, and getline are provided. More
sophisticated interactive features are provided
E: perl-Net-Telnet description-line-too-long because connecting to a TELNET port
ultimately means communicating with a program
E: perl-Net-Telnet description-line-too-long designed for human interaction.
These interactive features include the ability to
E: perl-Net-Telnet description-line-too-long specify a time-out and to wait for
patterns to appear in the input stream, such as
W: perl-Net-Telnet mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1)
[builder at rawhide SRPMS]$



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.