[Bug 228425] Review Request: gtkpod - Graphical song management program for Apple's iPod

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkpod - Graphical song management program for Apple's iPod
Alias: gtkpod-review

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228425





------- Additional Comments From tmz at pobox.com  2007-02-16 01:11 EST -------
(In reply to comment #6)
> Well, first check the "Timestamps" of
> http://fedoraproject.org/wiki/Packaging/Guidelines

Got it.  I'll add -p to the copy and installation of the icon.  Though neither
of them are config files so they shouldn't ever generate any sort of
.rpm{new,save} files.  And in the case of the .destkop file the timestamp of the
installed file will be whatever time the build was run as desktop-file-install
will update it.  (I'm now thinking I should have just kept the .desktop
generation in the spec file.)

> Keeping timestamps on the files as much as possible makes
> it easier to check:
> * if the vendor (like you) has modified the original file
> * and when the files are created or modified

The file will also be in cvs, so checking such things is always possible. :)

> Well, the ways to keep timestamps on the files automatically installed
> by "make install" differ according to packages, however,
> in general cases "make INSTALL="install -p" install" works.
> (there are many cases in that more fixes are needed). 

I've not run across any specfiles that do this.  It's not in the guidelines that
I can find (nor on the wiki anyplace, though my searching may just not have
found it).  I'd really like to see the pros and cons (if there are any)
discussed more.

I'll add it and test a little bit to see that it works as it should.  If either
of you has some pointers to places this has been discussed previously, please
pass them along.  My only concern is that I'll find out later that this can
cause some problems that I'm not aware of.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.