[Bug 228894] Review Request: rpcbind - converts RPC program numbers into universal addresses

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rpcbind -  converts RPC program numbers into universal addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228894


steved at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(steved at redhat.com)|




------- Additional Comments From steved at redhat.com  2007-02-16 16:56 EST -------
> Mixed tabs/spaces in the spec (URL line is tabbed, rest are spaces)
changes the tabs to spaces

> Mixed use of $RPM_BUILD_ROOT and %{buildroot}, please pick one.
%{buildroot} won... 

> Do you need to --prefix %{buildroot} ?  doesn't %configure set a proper prefix
> that will be used when you do DESTDIR= in %install?
True, --prefix %{buildroot} is not needed...

> Init files aren't supposed to be config files are they?
Per our IRC converstion, I would like to leave this in
since thats the way a number of other RPC/NFS related 
packages work.

> Why is there an 'exit 0' in  your %post ?
because someone complained about the %post not returning a zero
exit code... but it really not needed in this case so I remove it.

> security.c:24:27: error: rpcsvc/rquota.h: No such file or directory
added a quota requirement

so in the end here is the diff... 
diff -r1.1 rpcbind.spec
9c9
< URL:                          http://nfsv4.bullopensource.org
---
> URL:            http://nfsv4.bullopensource.org
19c19
< Requires: libtirpc
---
> Requires: libtirpc quota
49,50c49
<       --enable-debug \
<       --prefix=%{buildroot}
---
>       --enable-debug
65c64
< rm -rf $RPM_BUILD_ROOT
---
> rm -rf %{buildroot}
79d77
< exit 0

The source rpm and spec on my people page have been updated.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.