[Bug 227109] Review Request: pmd-3.6-1jpp - Scans Java source code and looks for potential problems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pmd-3.6-1jpp - Scans Java source code and looks for potential problems


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227109


jjohnstn at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jjohnstn at redhat.com         |overholt at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From jjohnstn at redhat.com  2007-02-16 17:19 EST -------
All problems below taken care of except binary build which is
blocked due to jaxen requirement.

http://www.vermillionskye.com/downloads/pmd-3.6-1jpp.1.src.rpm
http://www.vermillionskye.com/downloads/pmd.spec

MUST:
X - remove defines at top
  - fill in Name, Version, and Release fields

Fixed.

X - release should be of form Xjpp.Y%{?dist}

Fixed. 

X - instructions for source tar are incomplete

Fixed.

X - checking out source from CVS as specified and
    tarring does not result in same md5sum

Fixed.  Source replaced.

X correct buildroot
 - should be:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Fixed. 

X Vendor tag should not be used

Fixed.

X Distribution tag should not be used

Fixed.

X package successfully compiles and builds on at least x86
  - waiting on jaxen

X make sure lines are <= 80 characters

Fixed. 

X run rpmlint on the src RPMs
W: pmd non-standard-group Development/Testing
E: pmd no-cleaning-of-buildroot %install
W: pmd mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 30)

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.