[Bug 225750] Merge Review: file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: file


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225750


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mbacovsk at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From jpmahowald at gmail.com  2007-02-16 18:29 EST -------
Needs fixing:
- BuildRoot needs to be changed  http://fedoraproject.org/wiki/Packaging/Guidelines

Good:
+ License OK
+ follows naming guidelines
+ *.la cleaned
+ %clean section
+ devel package


rpmlint on x86_64:
rpmlint on file-4.19-2.fc7.src.rpm
W: file summary-ended-with-dot A utility for determining file types.
E: file tag-not-utf8 %changelog
W: file invalid-license distributable
E: file non-utf8-spec-file file.spec
W: file macro-in-%changelog _includedir
W: file macro-in-%changelog _datadir
W: file mixed-use-of-spaces-and-tabs (spaces: line 42, tab: line 10)
rpmlint on file-4.19-2.fc7.x86_64.rpm
W: file summary-ended-with-dot A utility for determining file types.
E: file tag-not-utf8 %changelog
W: file invalid-license distributable
E: file binary-or-shlib-defines-rpath /usr/bin/file ['/usr/lib64']
rpmlint on file-debuginfo-4.19-2.fc7.x86_64.rpm
E: file-debuginfo tag-not-utf8 %changelog
W: file-debuginfo invalid-license distributable
rpmlint on file-devel-4.19-2.fc7.x86_64.rpm
E: file-devel tag-not-utf8 %changelog
W: file-devel invalid-license distributable
W: file-devel no-documentation
rpmlint on file-libs-4.19-2.fc7.x86_64.rpm
E: file-libs tag-not-utf8 %changelog
W: file-libs invalid-license distributable
E: file-libs library-without-ldconfig-postin /usr/lib64/libmagic.so.1.0.0
E: file-libs library-without-ldconfig-postun /usr/lib64/libmagic.so.1.0.0


without-ldconfig seems bogus, it is in the spec.

Optional cleanup:
+ Change license to Distributable to shut rpmlint up
+ Change spec encoding to ASCII/UTF8
 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.