[Bug 226489] Merge Review: tftp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tftp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226489


mdehaan at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora_requires_release_note|fedora-review-
                   |?, fedora-review?, fedora-  |
                   |cvs?                        |




------- Additional Comments From mdehaan at redhat.com  2007-02-16 18:30 EST -------
rpmlint *.src.rpm:

W: tftp summary-ended-with-dot The client for the Trivial File Transfer Protocol
(TFTP).

This should be easy to fix :)

W: tftp no-url-tag

This should be something like Url:  http://foo.redhat.com at minimum or maybe
you could point at the upstream home of tftp.

W: tftp buildprereq-use tcp_wrappers-devel

I'm not really familiar with BuildRequires vs BuildPreRequires here, though it
seems like BuildRequires should work fine.

W: tftp mixed-use-of-spaces-and-tabs (spaces: line 54, tab: line 55)

This isn't hurting anything, though moving install up to the previous line would
make this go away.  Depends how much you care about rpmlint being whiney.

---

Other things I looked over:

service logic looks good.  xinetd is reloaded on an uninstall or after
newinstalls or upgrades.

config is noreplaced (good), permissions, good, etc.

One potential problem is that the BuildRoot doesn't contain version info (see
http://fedoraproject.org/wiki/Packaging/Guidelines)




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.