[Bug 225691] Merge Review: dhcp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: dhcp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225691





------- Additional Comments From dcantrell at redhat.com  2007-02-16 23:29 EST -------
(In reply to comment #1)
> Initial rpmlint scan:
> 
> [root at mdehaan devel]# rpmlint *.src.rpm
> W: dhcp invalid-license distributable
> 
> Given this is the nonstandard ISC license, ok.

Would something else be better in the License: field than 'distributible'?

> E: dhcp configure-without-libdir-spec
> 
> I'm not familiar enough with details to say whether or not this is ok.

The script called 'configure' in the source tree is not a standard GNU configure
script that most people know.  It's just named configure, but it's entirely
different.  Directory locations are specified in the site.conf file, which is
populated at the beginning of the %build block.

> W: dhcp macro-in-%changelog d
> W: dhcp macro-in-%changelog preun
> W: dhcp macro-in-%changelog postun
> W: dhcp mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 253)
> 
> AFAIK, these shouldn't break anything but if they can be corrected it will make
> rpmlint happier.

I made them all %% in the changelog entries to fix the warnings.
 
> W: dhcp patch-not-applied Patch13: dhcp-3.0.5-xen-checksum.patch
> 
> This patch is commented out in the spec file.  I would suggest removing it from
> the list of patches?

The Xen patch is an ongoing work-in-progress that was only recently disabled by
me.  I'd like to keep it in the RPM for now, but I'm not currently using it.

> Spec file looks good at first glance, though I'll look over this in greater
> depth next week.  Leaving as "?" to indicate review still in progress.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.