[Bug 217654] Review Request: TMDA - Tagged Message Delivery Agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TMDA - Tagged Message Delivery Agent


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217654





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-17 02:00 EST -------
Well, for 1.1.10-1.fc7:

* Scriptlets
  - Well, on my environ no one has /etc/ as the home directory.
    For the user tofmipd, I think the home directory should be
    %{_sysconfdir}/tmda or %{_sysconfdir}/tofmipd with the group
    of the directory set as tofmipd.

* Requires
----------------------------------------------
Requires(post): /sbin/chkconfig
Requires(preun):/sbin/chkconfig
Requires(pre):  fedora-usermgmt
Requires(postun):fedora-usermgmt
----------------------------------------------
  - All these are not needed for main package. These are needed
    by -tofmipd package.

  - By the way, why do you use the mixed use of
----------------------------------------------
  /sbin/service tofmipd stop &> /dev/null || :
  %{_initrddir}/tofmipd condrestart &> /dev/null || :
----------------------------------------------
    (i.e. use of /sbin/service v.s. directly calling
          scripts under %{_initrddir} ) ?
    On Fedora, the use of /sbin/service seems to be recommended,
    and Requires(....): /sbin/service is needed.

* Documentation
  - Check if the document "INSTALL" is needed.

* Functionality:
  On FC7 i386, "service tofmipd start" fails 100% as following:
----------------------------------------------------------------
[root at localhost bin]# service tofmipd start
Starting tofmipd: Traceback (most recent call last):
  File "/usr/bin/tmda-ofmipd", line 42, in <module>
    from TMDA import Util
  File "/usr/lib/python2.5/site-packages/TMDA/Util.py", line 27, in <module>
    import email
  File "/usr/lib/python2.5/site-packages/TMDA/pythonlib/email/__init__.py", line
118, in <module>
    import email.mime
ImportError: No module named mime
                                                           [失敗]

(The last word is Japanese, meaning "failed" in English)
----------------------------------------------------------------
  It seems that python tries to search email.mime module from 
  /usr/lib/python2.5/site-packages/TMDA/pythonlib/email/, because
  /email directory is found first. This is because
  /usr/lib/python2.5/site-packages/TMDA/pythonlib
  directory is inserted to the first place in sys.path. 

  However email.mime is on /usr/lib/python2.5/email/mime and
  python seems to search any more...

  The following diff seems to work.
----------------------------------------------------------------
--- tmda-ofmipd.orig    2007-02-16 00:09:06.000000000 +0900
+++ tmda-ofmipd 2007-02-17 15:20:39.000000000 +0900
@@ -36,7 +36,7 @@
     # Prepend /usr/lib/python2.x/site-packages/TMDA/pythonlib
     sitedir = os.path.join(sys.prefix, 'lib', 'python'+sys.version[:3],
                            'site-packages', 'TMDA', 'pythonlib')
-    sys.path.insert(0, sitedir)
+    sys.path.append(sitedir)
 
 
 from TMDA import Util
----------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.