[Bug 198839] Review Request: sear - WorldForge client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sear - WorldForge client
Alias: sear

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198839





------- Additional Comments From tibbs at math.uh.edu  2007-02-17 15:59 EST -------
OK, this builds and installs cleanly for me on current rawhide, and rpmlint is
quiet.

Basically this looks good except for the desktop file, which just needs to be
run through desktop-file-install.  I'm not sure if the X-Red-Hat-Base category
is problematic or not.

Review:
* source files match upstream:
   f7865c4ad2fd2a294f2d9e1a69f7fc4e52eab63e0c582c81676e15331e58534a
   sear-0.6.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.
* License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   sear = 0.6.3-1.fc7
  =
   /bin/sh
   libAtlas-0.6.so.1()(64bit)
   libAtlasCodecs-0.6.so.1()(64bit)
   libAtlasMessage-0.6.so.1()(64bit)
   libAtlasNet-0.6.so.1()(64bit)
   libAtlasObjects-0.6.so.1()(64bit)
   libGL.so.1()(64bit)
   libGLU.so.1()(64bit)
   libSDL-1.2.so.0()(64bit)
   libSDL_image-1.2.so.0()(64bit)
   libSDL_mixer-1.2.so.0()(64bit)
   libcal3d.so.12()(64bit)
   liberis-1.3.so.13()(64bit)
   libguichan.so.0()(64bit)
   libguichan_opengl.so.0()(64bit)
   libguichan_sdl.so.0()(64bit)
   libjpeg.so.62()(64bit)
   libmd3-0.2.so.1()(64bit)
   libmercator-0.2.so.4()(64bit)
   libpng12.so.0()(64bit)
   libsage.so.2()(64bit)
   libsigc-2.0.so.0()(64bit)
   libskstream-0.3.so.4()(64bit)
   libtiff.so.3()(64bit)
   libvarconf-1.0.so.6()(64bit)
   libwfmath-0.3.so.4()(64bit)
   libz.so.1()(64bit)
   wfut
* %check is not present; no test suite upstream.
  I have not tested this package but I'll give it a runthrough if I can get
  rawhide installed at work.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
X desktop file is present, but needs to be installed using desktop-file-install.  
  You'll also have to add BR: desktop-file-utils.  Also, I'm not really sure
  about having X-Red-Hat-Base in the category list

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.