[Bug 221004] Review Request: jeta - Horde SSH Java Applet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jeta - Horde SSH Java Applet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2007-02-17 23:40 EST -------
So, first the usual rpmlint errors that we see with these apps:

W: jeta conffile-without-noreplace-flag /etc/horde/jeta/conf.xml
W: jeta conffile-without-noreplace-flag /etc/horde/jeta/prefs.php.dist
  Indeed, these should not be noreplace.

E: jeta non-standard-uid /etc/horde/jeta/prefs.php apache
E: jeta non-standard-gid /etc/horde/jeta/prefs.php apache
E: jeta non-readable /etc/horde/jeta/prefs.php 0660
E: jeta non-standard-uid /etc/horde/jeta apache
E: jeta non-standard-gid /etc/horde/jeta apache
E: jeta non-standard-dir-perm /etc/horde/jeta 0770
E: jeta non-standard-uid /etc/horde/jeta/conf.xml apache
E: jeta non-standard-gid /etc/horde/jeta/conf.xml apache
E: jeta non-readable /etc/horde/jeta/conf.xml 0660
E: jeta non-standard-uid /etc/horde/jeta/prefs.php.dist apache
E: jeta non-standard-gid /etc/horde/jeta/prefs.php.dist apache
E: jeta non-readable /etc/horde/jeta/prefs.php.dist 0640
   Ownerships and permissions are as necessary for this application.

E: jeta htaccess-file /usr/share/horde/jeta/lib/.htaccess
   Indeed, this is an .htaccess file.
   I do now understand why rpmlint complains here: it is better to include
   such restrictions in the apache config file, and then apache can be set to 
   "AllowOverride none", improving performance.  Perhaps something to think
   about for future revisions.

So everything's fine with this package.  I had to enable it manually in
registry.php, and I think the horde package should just enable it.  I imagine
upstream will change things in the next horde release now that jeta is
officially released.

* source files match upstream:
   6abf801d70452f1186af1cd6415cde582dcb41b81fe30a1ef09db575cc46bd70
   jeta-h3-1.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.
* License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint output is OK.
* final provides and requires are sane:
  jeta-1.0-1.fc7.noarch.rpm
   config(jeta) = 1.0-1.fc7
   jeta = 1.0-1.fc7
  =
   config(jeta) = 1.0-1.fc7
   horde >= 3
   php >= 4.3.0

* %check is not present; manual testing shows that things work fine.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.