[Bug 225880] Merge Review: hal

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: hal


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-02-18 09:17 EST -------
Issues:

* use RPM_BUILD_ROOT or buildroot

*
BuildRequires: perl-XML-Parser
should certainly be replaced by
BuildRequires: perl(XML::Parser)

* Missing
Requires(post): /sbin/ldconfig
Requires(pre): /usr/sbin/useradd
Requires(postun): gawk, grep, coreutils, /sbin/ldconfig
I guessed that triggerpostun is associated with Requires(postun), maybe this
is wrong.

* There are no static libraries, the -devel %description should be updated

* /etc/dbus-1/system.d/hal.conf should certainly be %config(noreplace)

* Why is %doc commented out? And also
%{_datadir}/doc/hal-%{version}/conf/*
seems wrong to me but it's not completely obvious.

* remove Application; X-Red-Hat-Base; from desktop file Categories
remove X-Desktop-File-Install-Version=0.10 from desktop file

* --vendor should be fedora and not redhat. There is a cryptic comment
saying that it shouldn't change during release but I guess we are 
between releases...

* shouldn't hal-info be put in another package?

Suggestions:

* replace %defattr(-,root,root) with %defattr(-,root,root,-)

* replace
cp -f %{SOURCE1} $RPM_BUILD_ROOT%{_datadir}/hal/fdi/policy/10osvendor/
with
cp -p %{SOURCE1} $RPM_BUILD_ROOT%{_datadir}/hal/fdi/policy/10osvendor/
 


There is an issue of directory ownership for /usr/share/gtk-doc/html/,
but it is not obvious how to solve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.