[Bug 225639] Merge Review: cdrdao
bugzilla at redhat.com
bugzilla at redhat.com
Mon Feb 19 14:37:00 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: cdrdao
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225639
------- Additional Comments From denis at poolshark.org 2007-02-19 09:36 EST -------
What is the rationale for building against the version of cdrtools that's part
of the tarball ? That version if particularly old, and I left it there mainly
for non-linux builds...
I guess we should also merge this package with gcdmaster in Extras, once the
build system merge is complete.
other issues:
- libvorbis-devel Require is not necessary, it's only used if you build gcdmaster
- xcdrdao.desktop source is unused
- make invocation should use %{?_smp_mflags}
- the --with-pccts* configure options are unnecessary
- use make install DESTDIR=$RPM_BUILD_ROOT instead of %makeinstall
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list