[Bug 211336] Review Request: adesklets - A simple architecture for desktop applets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adesklets - A simple architecture for desktop applets
Alias: adeskets

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211336





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-19 09:47 EST -------
Umm... 0.6.1-4 still has a lot of issues to be fixed
I only checked packaging issues and I have not installed
this yet.

* The following issue:

> Unfortunately, I am unable to remove
> /usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod
> I need to see what mistake I made so I can fix them.
  - First of all, the place you wrote "rm -rf" is wrong.
    (Why is this before "make install")?
  - And check the macro {perl_vendorlib} actually returns.
-------------------------------------------------------------
[tasaka1 at localhost adesklets]$ rpm --eval %perl_vendorlib
/usr/lib/perl5/vendor_perl/5.8.8
-------------------------------------------------------------

* BuildRequires
  - desktop-file-install requires "desktop-file-utils" for
    BuildRequires.
  - Still X related packages are missing from BuildRequires.
-------------------------------------------------------------
checking for fontconfig... no <- HERE
configure: WARNING:
-----------------------------------------------------
`fontconfig' was not found on your system.
Although `adesklets' will work anyway system-wide
automatic font detection will not occur:
it is therefore quite possible that only the
default font provided with the package will display.
-----------------------------------------------------
checking for fork... yes
checking for X... no <- HERE
-------------------------------------------------------------
    and
-----------------------------------------------------
you choosed to perform an `X Window less' build -
which means you will eventually end up with
a strictly command line program free of all
dependencies on xlib. If it is not what you intended
please reconfigure. For this to work you do need first
to configure your Imlib2 incantation for not using
X Window itself.
-----------------------------------------------------

* Macros
  - The following macros are not defined.
-----------------------------------------------------
[tasaka1 at localhost i386]$ rpm --eval %_install_info
%_install_info
-----------------------------------------------------
  - And check "Texinfo" section of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
      * Requirement for info package is missing
      * post does not the value 0 as $1
      * This is non-safe on non-docs install.
http://www.redhat.com/archives/fedora-maintainers/2007-January/msg00017.html

* Perl temp file
-----------------------------------------------------
W: adesklets hidden-file-or-dir
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
W: adesklets perl-temp-file
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
-----------------------------------------------------
  - Usually .packlist files should be removed.

* Permission
-----------------------------------------------------
E: adesklets non-standard-executable-perm
/usr/lib/perl5/vendor_perl/5.8.8/updateproto.pl 0555
-----------------------------------------------------
  - Why should this file should have 0555 (not 0755 or 0644) permission?

* Encodings
-----------------------------------------------------
W: adesklets file-not-utf8 /usr/share/info/adesklets_fr.info.gz
-----------------------------------------------------
   Please change the encodings to UTF-8.

* Desktop files
  - Categories are not right.
-----------------------------------------------------
Categories=User Interface;Desktop;
-----------------------------------------------------
    while desktop-file-validate complains:
-----------------------------------------------------
warning: Categories values must be one of 
"AudioVideo", "Audio", "Video", "Development", "Education", 
"Game", "Graphics", "Network", "Office", "Settings", "System", 
"Utility", "Building", "Debugger", "IDE", "GUIDesigner", 
"Profiling", "RevisionControl", "Translation", "Calendar", 
"ContactManagement", "Database", "Dictionary", "Chart", "Email", 
"Finance", "FlowChart", "PDA", "ProjectManagement", "Presentation", 
"Spreadsheet", "WordProcessor", "2DGraphics", "VectorGraphics", 
"RasterGraphics", "3DGraphics", "Scanning", "OCR", "Photography", 
"Viewer", "DesktopSettings", "HardwareSettings", "PackageManager", 
"Dialup", "InstantMessaging", "IRCClient", "FileTransfer", 
"HamRadio", "News", "P2P", "RemoteAccess", "Telephony", 
"WebBrowser", "WebDevelopment", "Midi", "Mixer", "Sequencer", 
"Tuner", "TV", "AudioVideoEditing", "Player", "Recorder", 
"DiscBurning", "ActionGame", "AdventureGame", "ArcadeGame", 
"BoardGame", "BlocksGame", "CardGame", "KidsGame", "LogicGame", 
"RolePlaying", "Simulation", "SportsGame", "StrategyGame", "Art", 
"Construction", "Music", "Languages", "Science", "Astronomy", 
"Biology", "Chemistry", "Geology", "Math", "MedicalSoftware", 
"Physics", "Amusement", "Archiving", "Electronics", "Emulator", 
"Engineering", "FileManager", "TerminalEmulator", "Filesystem", 
"Monitor", "Security", "Accessibility", "Calculator", "Clock", 
"TextEditor", "Core", "KDE", "GNOME", "GTK", "Qt", "Motif", 
"Java", "ConsoleOnly", "Screensaver", "TrayIcon", "Applet", "Shell"
-----------------------------------------------------
    - And what is the following?
-----------------------------------------------------
Exec=twf
-----------------------------------------------------

* Again Duplication of system libraries
   - /usr/share/adesklets/Vera.ttf
     Vera.ttf is included in bitstream-vera-fonts rpm and should not be 
     included in this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.