[Bug 220890] Review Request: libcdaudio - Control operation of a CD-ROM when playing audio CDs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcdaudio - Control operation of a CD-ROM when playing audio CDs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220890


jwilson at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




------- Additional Comments From jwilson at redhat.com  2007-02-19 15:19 EST -------
* source files match upstream:
  - 15de3830b751818a54a42899bd3ae72c libcdaudio-0.99.12p2.tar.gz
  - 15de3830b751818a54a42899bd3ae72c libcdaudio-0.99.12p2-orig.tar.gz
* package meets naming and versioning guidelines
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
! BuildRoot is not correct, should be:
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* license field matches the actual license.
* license is open source-compatible.  GPL2, License text included in package.
  - rpmlint complains about GPL2, but rpmlint probably shouldn't...
* latest version is being packaged.
! BuildRequires are proper.
  - Technically, nothing wrong with gcc-c++, but its listed in the
    packaging guidelines as an exception that should be left out,
    since its always in the minimum build root.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (F7/x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
  - Only complaint is the Warning about GPL2, which I say we ignore.
* final provides and requires are sane:
    libcdaudio provides/requires:
    --
    libcdaudio.so.1()(64bit)  
    libcdaudio = 0.99.12p2-8.fc7
    --
    libcdaudio.so.1()(64bit)

    libcdaudio-devel provides/requires:
    --
    libcdaudio-devel = 0.99.12p2-8.fc7
    --
    libcdaudio = 0.99.12p2-8.fc7
    libcdaudio.so.1()(64bit)
    pkgconfig
* %check is n/a
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers in -devel
  - cdaudio.h ought to be installed w/-p to preserve timestamps,
    but that looks to be upstream's fault
* pkgconfig files in -devel, properly requires pkgconfig
* no libtool .la droppings.
* not a GUI app.


I think the only MUSTFIX item is the BuildRoot, but I'd suggest also dropping
the BR: on gcc-c++. Whether or not to patch the Makefile to install the header
w/-p I'll leave up to you.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.