[Bug 225655] Merge Review: coreutils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: coreutils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225655





------- Additional Comments From pertusus at free.fr  2007-02-19 18:08 EST -------
(In reply to comment #13)

> Depending on itself: Er.. can you be more specific?  Which line are you
looking at?

The build is depending on coreutils commands, like mkdir, install, cp,
mv. It also depends on find (in find_lang), bzip2, m4 (through autoconf),
perl. Build dependency on bzip2 and perl could be avoided, but in any
case I can't see how depending on coreutils could avoioded completely. 
It would depend through make, gcc and certainly some libs anyway.

> Huge amount of patches: there are just 13 patches, and work is being done
> upstream to integrate several of them.  Others will never get upstream.

13 patches is a lot, for a package which has an active upstream, 
and patches are not related with integration to fedora. Anyway I 
guess you know much better what to do than me, still it may be worth 
retrying patch submission after time has gone by and things evolved.

> FHS macros: this was addressed in comment #2.

No, it wasn't. I said
  /etc, /var and /usr/bin are hardcoded in the spec file, maybe they could
  be changed to macros.
in comment #2, there is mention of /sbin and /bin. In fact for /etc and
/var it is in fact a bad idea since it is a substitution in a doc file, 
it is better to leave them as is, so you can forget about /etc and
/var, sorry for the noise.

There is still one /usr/bin:
for i in env cut; do ln -sf ../../bin/$i $RPM_BUILD_ROOT/usr/bin; done


Suggestion:
remove / in RPM_BUILD_ROOT/%{_datadir}

> sed instead of perl: no need to change this

This is more a suggestion, but it may be worth trying to avoid unnedeed
build dependency in the hope to reduce further the build base; in my
opinion it would be nice not to have perl in every build.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.