[Bug 226449] Merge Review: syslinux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: syslinux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226449





------- Additional Comments From mdehaan at redhat.com  2007-02-19 18:29 EST -------
Initial scan...

E: syslinux tag-not-utf8 %changelog

Encodings as appearing from "file" do seem odd. 
file syslinux.spec 
syslinux.spec: ISO-8859 make commands text

W: syslinux no-url-tag

This should probably be a Url:  http://syslinux.zytor.com

E: syslinux non-utf8-spec-file syslinux.spec

See earlier comments on file format.

W: syslinux unversioned-explicit-provides syslinux-devel

Probably should add the version here.

E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux
E: syslinux hardcoded-library-path in %{_prefix}/lib
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux
E: syslinux hardcoded-library-path in %{_prefix}/lib/libsyslinux*
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.com
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.exe
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.c32
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.bin
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.0
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/memdisk
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.pl
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/mkdiskimage
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/syslinux
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/syslinux-nomtools
E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/com32

I'm not entirely sure what Fedora Extras guidelines say here for packages that
are exclusively 32bit, but I would expect to see %{_libdir} here.  Maybe
syslinux gets an exception?

W: syslinux mixed-use-of-spaces-and-tabs (spaces: line 59, tab: line 58)

This should be relatively easy to fix and isn't a major problem.

----

Other comments:

(+) Biuldroot, license, and other header info looks good with the exception of
the missing URL.   ExclusiveArch is right for what syslinux supports, etc.

(?) Can Requires: /usr/include/gnu/stubs-32.h be replaced by the package that
provides it (glibc-devel) or is there a reason for doing this?

(?) Doesn't specify a specific version of perl or netpbm-progs, though
specifying some minimum version would be desirable.

(+) Files section looks fine.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.