[Bug 229154] Review Request: konwert - Converter of character encodings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: konwert - Converter of character encodings


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229154


lxtnow at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NOTABUG




------- Additional Comments From lxtnow at gmail.com  2007-02-19 18:37 EST -------
Indeed,

There's some things which should be fix.
-------------------------------
spec file:
-------------------------------
 ** BuildRequires

 - BR perl is useless as it requires by default installed package (such as 
xorg-x11-server-Xorg)

 ** %package Devel

 - Requires: konwert SHOULD be : requires:  %{name} = %{version}-%{release}
 - Group should be Development/Tools

 ** %description devel

 -  SHOULD only describe contains about -devel package, not   
  main package.

 ** %build

 - OPTFLAGS="$RPM_OPT_FLAGS %{!?debug:-fomit-frame-pointer}" can be remove.
   Build and work well without this.
 - in this case, use OPTFLAGS="$RPM_OPT_FLAGS -fno-rtti -fno-exceptions \   
   -fno-implicit-templates" instead of
 - use make instead %{_make}.

 ** %install 

 - use make install instead of %{_make} install.
 - The use of : prefix=$RPM_BUILD_ROOT%{_prefix} \
	        mandir=$RPM_BUILD_ROOT%{_mandir} \
	        mydocdir=$RPM_BUILD_ROOT%{_docdir}/konwert-%{version} \
	        perl=%{_bindir}/perl \
	        libdir=$RPM_BUILD_ROOT%{_libdir} \
   sound good and work except mydocdir= (see below for more explaination).
   after have a look on build.log (and Makefile), i can see the use of "sed"
   to change default location (which match with fedora install location) 
   such as /usr/share/ by /usr/local/share).
   Can be fix by patching Makefile but require more working time.
 - the use of "dontfixmanconfig=1", check if it's necessary and comment why.
 - keep timestamps on make install by addind "INSTALL=install -p"

** %post

 - Doesn't look good.

** %files and %files devel

 - doesn't sound good at all.
 - The use of "%{_docdir}/konwert-%{version}/en/*" is deprecated and must be drop.
   All doc MUST be set in %doc just after %defattr macros.
 - the use of %attr(755,root,root):
   Personnaly, I prefere use chmod command in %install section and comment the
reason of.
 - You package doesn't own the %{_datadir}/%{name}.
 - The use of %lang(p1) is useless
 - some files mentioned twice.
 - %{_mandir}/man1 instead of %{_mandir}/man*/*
 - You don't need to mentione explicitly all files, just the use of main
location is enough.
   such as %{_datadir}/%{name} (and own in the same time)

Spec file doesn't meet the packeging Guidlines, see
http://fedoraproject.org/wiki/Packaging/Guidelines.

--------------------------
 Rpmlint output
--------------------------

 ** From srpm file: clean.

 ** From main rpm package:

   W: konwert file-not-utf8 /usr/share/man/man1/filterm.1.gz
   W: konwert file-not-utf8 /usr/share/man/pl/man1/trs.1.gz
   W: konwert file-not-utf8 /usr/share/man/pl/man1/filterm.1.gz
   W: konwert file-not-utf8 /usr/share/man/pl/man1/konwert.1.gz
   W: konwert file-not-utf8 /usr/share/man/man1/konwert.1.gz

 - Can be fix by the use of iconv command in %prep or %install.

   W: konwert one-line-command-in-%post /usr/share/konwert/aux/fixmanconfig
 
 - As i mentioned above, this is not quite good.


** From -devel rpm package: clean.

** From -debuginfos rpm package:

  E: konwert-debuginfo empty-debuginfo-package

 - this package contains no files.
   rpmbuild not being able to strip the binaries.


If i forgot to mentione something, i will post

FE-REVIEW

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.