[Bug 226479] Merge Review: tcl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tcl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226479


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?




------- Additional Comments From wart at kobold.org  2007-02-19 21:01 EST -------
(In reply to comment #11)
> The use of %{_libdir} looks ok, but the backwards-compatible link is still wrong:
> 
> cd %{_datadir}
> ln -s %{name}%{majorver} $RPM_BUILD_ROOT/%{_libdir}/%{name}%{majorver}
> 
> This creates the same recursive link:
> lrwxrwxrwx 1 root root 6 2007-02-15 11:47 /usr/lib/tcl8.4 -> tcl8.4

Additionally, the 'cd %{_datadir}' changes the current working directory.  The
sed command shortly after makes use of $PWD when modifying the tclConfig.sh file:

sed -i -e "s|$RPM_BUILD_ROOT/unix|%{_libdir}|;
s|$RPM_BUILD_ROOT|%{_includedir}/%{name}-private|"
$RPM_BUILD_ROOT/%{_libdir}/%{name}Config.sh

This results in an unusable tclConfig.sh file because the paths to the header
files still use the build directory on the build server.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.