[Bug 229291] Review Request: thinkfinger - A driver for the UPEK/SGS Thomson Microelectronics fingerprint reader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: thinkfinger - A driver for the UPEK/SGS Thomson Microelectronics fingerprint reader


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229291


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2007-02-19 21:49 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
82c3b74c369fc231379d48af9e8ff851  thinkfinger-0.2.2.tar.gz
82c3b74c369fc231379d48af9e8ff851  thinkfinger-0.2.2.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Minor: The Source URL doesn't seem to work here...
http://downloads.sourceforge.net/thinkfinger/thinkfinger-0.2.2.tar.gz
does seem to work. Not sure if that will work everywhere given sourceforge.

2. Would it be worth filing a RFE against pam to include the line
needed in /etc/pam.d/system-auth? It should ignore it if the module isn't available
I think, and will only work for users that setup a fingerprint.
Perhaps something to think about when this package is more mature.

Works great for me here on a fc6 laptop.   

I don't see any blockers here... you can change the source URL if you like
when you check it in, or leave it as is.

This package is APPROVED.

Don't forget to close this package review request NEXTRELEASE once it's
been imported and built. See:
http://www.fedoraproject.org/wiki/CVSAdminProcedure
for new package import procedures.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.