[Bug 220890] Review Request: libcdaudio - Control operation of a CD-ROM when playing audio CDs

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 21 22:27:28 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcdaudio - Control operation of a CD-ROM when playing audio CDs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220890





------- Additional Comments From Axel.Thimm at ATrpms.net  2007-02-21 17:27 EST -------
(In reply to comment #16)
> You do get a new buildroot with every invocation of rpmbuild, don't you?
> Effectively, these newly created buildroots pile up to a gigantic pile of
> crap.

(In reply to comment #18)
> Please do try the proposed buildroot with --short-circuit and
> prove that it doesn't do what I've written in comment 16. Option
> -u does not prevent mktemp from returning a new path with
> every invocation.

Prove? It's true that it *returns* a new buildroot on every invocation, but it
does not *create* it, no "gigantic pile of crap" is generated by merely invoking
rpmbuild as you wrote. E.g. rpmbuild -bp/-bc are not creating anything. 

And that's why --short-circuit has nothing to do with this here, unless you
would had been suggesting packages that use %buildroot in %prep and %build,
which (almost) all agree to be A Bad Thing.

Anyway whoever is smart enough to make diligent use of --short-circuit will be
able to use his favourite external %buildroot setting as well.

But for the normal non-short-circuit case there is still a small bitter pill
left, that seperated %install and %clean of rpmbuilds will leave buildroots behind.

Ceterum censeo clausulum definendam buildrootium coactum esse esse delendam.

Ceterum censeo 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list