[Bug 226448] Merge Review: sysklogd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sysklogd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226448


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review-              |fedora-review+




------- Additional Comments From kevin at tummy.com  2007-02-21 18:50 EST -------
2. ok. 

Checking out a copy from the above cvs, making a .tar.gz and diffing between
that version and whats shipped in your src rpm shows one diffrence... 
you have a sysklogd.spec file in your tar.gz, which doesn't exist in cvs. 
I assume thats generated from the sysklogd.spec.in, so it can be ignored. 

Can you add a comment to the spec before the Source line indicating how someone 
could check out the source from rhlinux cvs? something like: 

# The source for this package was pulled from cvs.
# Use the following commands to generate the tarball:
#  export CVSROOT=:pserver:anonymous at rhlinux.redhat.com:/usr/local/CVS
#  cvs login (hit return)
#  cvs co sysklogd
#  mv sysklogd sysklogd-%{version}rh
#  tar -czvf sysklogd-%{version}rh.tar.gz sysklogd-%{version}rh

5. There is indeed a dist tag. That was an old/outdated comment. 

I see no further blockers here. If you could make that comment change, we can
call this package APPROVED. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.