[Bug 229533] Review Request: perl-Template-GD - GD plugin(s) for the Template Toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Template-GD - GD plugin(s) for the Template Toolkit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229533


jpo at di.uminho.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jpo at di.uminho.pt
OtherBugsDependingO|163776                      |163778
              nThis|                            |
               Flag|                            |fedora-review-




------- Additional Comments From jpo at di.uminho.pt  2007-02-21 22:27 EST -------

Needswork
---------

* several missing requirements

  Current requirements

  $ rpm -qpR perl-Template-GD-2.66-1.noarch.rpm
  perl(:MODULE_COMPAT_5.8.8)
  perl(GD)  
  perl(base)  
  perl(strict)  
  perl(warnings)
  ...

  Missing requirments:

  The same base modules that are listed as BR.
  rpmbuild fails to detect "use base <perlmodule>" requirements.

  $ grep -r -h "\buse" * | sort | uniq
  ...
  use base qw( GD::Graph::area Template::Plugin );
  use base qw( GD::Graph::bars3d Template::Plugin );
  use base qw( GD::Graph::bars Template::Plugin );
  use base qw( GD::Graph::lines3d Template::Plugin );
  use base qw( GD::Graph::linespoints Template::Plugin );
  use base qw( GD::Graph::lines Template::Plugin );
  use base qw( GD::Graph::mixed Template::Plugin );
  use base qw( GD::Graph::pie3d Template::Plugin );
  use base qw( GD::Graph::pie Template::Plugin );
  use base qw( GD::Graph::points Template::Plugin );
  use base qw( GD::Text::Align Template::Plugin );
  use base qw( GD::Text Template::Plugin );
  use base qw( GD::Text::Wrap Template::Plugin );
  use base 'Template::Plugin';
  ...

* find: change order of the options

  -find $RPM_BUILD_ROOT -type d -depth ...
  +find $RPM_BUILD_ROOT -depth -type d ...

  Avoids the warning: "find: warning: you have specified the -depth option
after a non-option argument -type, but options are not positional (-depth
affects tests specified before it as well as those specified after it).  Please
specify options before other arguments."



Other notes/sugestions
----------------------

* drop the perl BR

* add a slash to the end Template directory: it's easier to detect that we
  are planning owning the directory and everything inside it.

  -%{perl_vendorlib}/Template
  +%{perl_vendorlib}/Template/


jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.