[Bug 225257] Merge Review: aspell-af

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 22 10:41:17 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: aspell-af


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225257


mmaslano at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jspaleta at gmail.com          |varekova at redhat.com
                 CC|                            |mmaslano at redhat.com




------- Additional Comments From mmaslano at redhat.com  2007-02-22 05:41 EST -------
Source:
W: aspell-af summary-ended-with-dot Afrikaans dictionaries for Aspell.
W: aspell-af rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
W: aspell-af rpm-buildroot-usage %build echo "DEST_DIR = $RPM_BUILD_ROOT" >>
Makefile
W: aspell-af rpm-buildroot-usage %build echo "dictdir =
${RPM_BUILD_ROOT}%{_libdir}/aspell-0.60" >> Makefile
W: aspell-af rpm-buildroot-usage %build echo "datadir =
${RPM_BUILD_ROOT}%{_libdir}/aspell-0.60" >> Makefile
E: aspell-af no-cleaning-of-buildroot %install

rm -rf from prep to clean
$RPM_BUILD_ROOT should not be touched during %build

Arch:
W: aspell-af summary-ended-with-dot Afrikaans dictionaries for Aspell.
E: aspell-af no-binary -> should be noarch
E: aspell-af only-non-binary-in-usr-lib -> will be fix by previous
W: aspell-af no-documentation -> not a problem

Release number should be whole number.
Wrong buildroot, should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

md5sum: bde617a195e70364f96eea71cf71a333 == bde617a195e70364f96eea71cf71a333

Permission should be: %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list