[Bug 226133] Merge Review: mc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226133


dmitry at butskoy.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmitry at butskoy.name




------- Additional Comments From dmitry at butskoy.name  2007-02-22 08:52 EST -------
There are a couple of patches which alter the default upstream source.

AFAIK the Fedora's policy against "new feature" patches is "send it upstream".

Certainly, the patches for compatibility (i.e. big utf8 patch, which allows MC
to be looked under UTF-8 locale the same way as upstream's MC is looked) or for
scalability (new locales, new optional modules etc.) are allowed. But there are
at least "mc-showfree" and "mc-utf8-look-and-feel" patches (and maybe even more)
which do not match that criteria.

Such kind of patches should first be sent upstream. It is exactly the upstream's
decision whether apply them or not. Else you should fork the project with
another name etc...


Well, sorry for the words above, actually I'm not so formal. Since these two
patches already present for a while, let's it be. But to be correct, some things
are needed:
- Config option to switch new "look-and-feel" on/off must be added
- This option and already existing "showfree" option should not be enabled by
default.

In other words, the fresh installed Fedora's MC should be looked closely to
vanilla upstream version.

MC is one of "every day and every hour" applications for me. When the habitual
"look and feel" suddenly changes, and there is no way to switch off, it is
painful enough for users...


P.S. The names of patches should normaly have form "mc-version-name.patch",
where "version" points the first upstream version when the patch was appeared.
If the upstream is actually cvs, then use cvs date for it.

P.P.S. I hope it is not needed to re-open this bugzilla ticket? ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.