[Bug 229651] Review Request: Democracy - A internet TV video player

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 22 15:11:27 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Democracy - A internet TV video player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229651





------- Additional Comments From lxtnow at gmail.com  2007-02-22 10:11 EST -------
please, use %{_mandir}/man1/ instead of %{_datadir}/man/man1/

> # Include files and dirs below %{python_sitelib} (for noarch packages) 

Where ?

the use of cd platform/gtk-x11 looks good.
personnaly, i prefer to use pushd-command to enter in some directory and
popd-command to exit this one (same thing for %build section).
such as:
----
pushd gtk-x11
python setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
popd
----
i think it's better for a clean review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list