[Bug 229651] Review Request: Democracy - A internet TV video player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Democracy - A internet TV video player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229651


rdieter at math.unl.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rdieter at math.unl.edu




------- Additional Comments From rdieter at math.unl.edu  2007-02-22 11:54 EST -------
Looking good, I can review this.

1. SHOULD simplify things and just include in %files:
%{python_sitearch}/democracy/
instead of all the %dirs and * globbing.

2.  Requires: firefox
Other apps that build against firefox-devel need/use a *versioned* requires 
here, in effect Require'ing the same version of firefox they were built 
against.  Is that the case here?  (or maybe not worry about it (: )

3.  Requires: python-abi ...
shouldn't be explictly required (when using python >= 2.4 anyway).

4.  Requires:	xine-lib gnome-python2-gtkmozembed libfame gnome-python2-gconf 
dbus-python
Are *all* of these really explicitly required?  In particular, xine-lib 
libfame should get auto'req'd by rpm (if not, it's ok to keep the Requires).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.