[Bug 229591] Review Request: lshw - Hardware Lister (lshw)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lshw - Hardware Lister (lshw)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229591





------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-22 14:54 EST -------
Here we go: comments after successfully building in mock/rawhide/i386:
- build step does not take into account $RPM_OPT_FLAGS
- the generated debuginfo package is empty
- according to wiki/PackagingGuidelines/Conditional dependencies, the GUI rpm
should be generated by default, so I suggest to use as default the "with_gui"
flag rather then "without gui"
- what is the rationale behind installing the binaries with bin.bin as owner and
555 as permissions?
- I see no reason in defining the name, version and release in private macros
and then using them to set the Name, Version and Release tags. You can as well
define directly those three and use them later in the spec.
- last but nit least, rpmlint says
E: lshw description-line-too-long
Please split the line in chunks of no more then 72 chars

PS: in the previous comment, the line about the Vendor tag should have been:
Vendor should not be used, it will be set by the build system (see
wiki/PackagingGuidelines/Tags)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.