[Bug 228425] Review Request: gtkpod - Graphical song management program for Apple's iPod

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkpod - Graphical song management program for Apple's iPod
Alias: gtkpod-review

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228425


lxtnow at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From lxtnow at gmail.com  2007-02-23 08:03 EST -------
Review:

OK package builds in mock (FC-5 FC-6 FC-Devel i386,x86_64).
OK rpmlint is silent for both SRPM and RPM.
OK source files match upstream.
OK package meets naming and packaging guidelines.
OK specfile is properly named, is cleanly written
OK Spec file is written in American English.
OK Spec file is legible.
OK dist tag is present.
OK build root is correct.
OK license is open source-compatible.
OK License text is included in package.
OK %doc is good
OK %doc does not affect runtime.
OK BuildRequires are proper.
+  Vendor is set to Fedora.
OK %clean is present.
OK package installed properly.
OK Macro use appears rather consistent.
OK Package contains code, not content.
OK no static libraries.
OK no translations are available.
OK Does owns the directories it creates.
OK no duplicates in %files.
OK Changelog is present and clean.
OK file permissions are appropriate.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.