[Bug 222042] Review Request: GDAL - Geospatial Data Abstraction Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GDAL - Geospatial Data Abstraction Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222042





------- Additional Comments From cbalint at redhat.com  2007-02-24 09:43 EST -------
update:
Spec URL: http://openrisc.rdsor.ro/gdal.spec
SRPM URL: http://openrisc.rdsor.ro/gdal-1.4.0-8.src.rpm

*mock fedora-devel builds it fine.
*rpmlint complain nothing.

include my fixes by the review:

(In reply to comment #42)
> Well, for 1.4.0-7.fc7:
> 
> * BuildRequires
>   - mockbuild log says:
> -------------------------------------------------------
> checking for Xerces C++... disabled
> -------------------------------------------------------
>     Can this be enabled by xerces-c-devel?

yes.
enabled.
(lots of stupid hardcoded paths, so workaround configure script)

> 
> * User dependent rebuild condition?
>    - mockbuild log says:
> -------------------------------------------------------
> Writing
> /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto/Geo/GDAL/Const/.packlist
> Appending installation info to
> /usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod
> /bin/sh: /usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod: 
Permission
> denied
> make[3]: [doc_site_install] Error 1 (ignored)
> make[3]: Leaving directory `/builddir/build/BUILD/gdal-1.4.0/swig/perl'
> make -f Makefile_Geo__OGR install
> -------------------------------------------------------
>      Well, this can be ignored for mockbuild, however, is this
>      dangerous on rebuilding this package as root?

busted away into > /dev/null the generation of those files.

> 
> * BuildRoot
>   - BuildRoot does not follow current Fedora guideline
>     (please check "Build root tag" section of
>      http://fedoraproject.org/wiki/Packaging/Guidelines)

fixed. i apologise for this, its elementary thing :-(
 
> * Header files location
>   - Well, I think all the header files in -devel package should
>     be hidded under %{_includedir}/%{name} to avoid namespace
>     conflict.

moved.

>   - And I suggest to fix %{_bindir}/gdal-config accordingly.
>   - By the way what does "CONFIG_DEP_LIBS" in gdal-config mean?

dont know, but can say _sure_ that grass use it ;-) !
(fixed other minor nits with it, so that long paths looks coherently now) 

> * Directory structure
>   - Well,
> ---------------------------------------------------------
> # move python in the right path
> mv %{buildroot}%{_bindir}/*.py %{buildroot}%{_datadir}/gdal
> cp -p pymod/samples/*.py %{buildroot}%{_datadir}/gdal
> ---------------------------------------------------------
>     Just explain why putting these python scripts under %{_bindir}
>     is not right?

1) ok. i leave in bindir those in -python package.
2) but samples/* moved (-x mode) in docs section of -python package.

> 
> * .la files
>   - The following files are installed.
> ----------------------------------------------------------
> /usr/lib/python2.5/site-packages/_gdalmodule.la
> ----------------------------------------------------------

excluded.

> * Redundant dependency
>   - Currently the following explicit dependency are rather
>     redundant.
> ----------------------------------------------------------
> Requires: python >= 2.4
> Requires: perl >= 5.8
> ----------------------------------------------------------

removed those. obviously unnessesary.

> Check for documentation files and source files may take more
> time...

  Included more docs, i think _all_ posible of tham. Olso included some  
autogenerated pdf flavors but only from folders where tetex pdf make not 
crash ;-)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.