[Bug 192436] Review Request: xorg-x11-server-Xgl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-server-Xgl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192436





------- Additional Comments From alcapcom at gmail.com  2007-02-24 17:42 EST -------
> - The files
> Source1:	noXgl
> Source2:	README.Fedora
> need a xorg-x11-server-Xgl- prefix and get renamed to their final names during
> install (that's done already), as other source packages that people might
> install in parallel could contain files with the same filenames

fixed

> - this
> # remove uneeded files
> needs a more verbose comment -- why are all of those unneeded (it's obvious for
> the .la files, but not for the rest)?

comment "these file are already provided by the Xorg package", is that enough?

> - the %post script looks just crazy -- sorry, but such things are frowned upon
> and should be avoided as much as possible. They might be needed in some very
> rare situations, but then they need a comment. I don't think they are needed here

Have move the launch of XGL to xsessions, but the problem is that it's necessary
to add a .desktop file by WM and I am not sure is that well.

Any other idea?

> - This
> %defattr(-, root, root)
> should be
> %defattr(-, root, root, -)

fixed
 
> - and how does one check out the snapshot to check that the code actually
> matches upstream? Needs a comment, too. (/me curses stupid upstream projects
> that have no proper release scheme)

fixed
	
The package is build for the moment but i work tomorrow, so i should push it 
after 9h pm.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.