[Bug 229826] Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826





------- Additional Comments From bbbush.yuan at gmail.com  2007-02-25 09:55 EST -------
(In reply to comment #12)
> * %description is right (even a bit too long now ;-). It should be 
> cut at about 80 columns. 
> s/conviniently/conveniently/
> s;Try to $HOME/.chmsee ;Try to remove $HOME/.chmsee;
> 

corrected. thx.

> * I think that the chmsee-icon.png file should be kept in pixmaps, even
> though it is also in the theme directory.
> 

ok.

> * in $RPM_BUILD_ROOT/%{_datadir}, / is unuseful.
> 

removed.

> * you should keep timestamps when installing data files, adding
> -p to install call.
> 

done.

> * What about my proposal, using the same file for 
> /usr/share/icons/gnome/48x48/mimetypes/gnome-mime-application-x-chm.png
> 
> It seems to me that the file used should be a file specific of the 
> file type, not a file corresponding with an application. Therefore
> the file chmfile.png from gnochm seems a better candidate to me than
> chmsee-icon.png. 
> 
> As a side note, I don't like that much that icon file, I prefer the 
> ones that are with xchm, I find them better looking, and there are 
> different sizes (and they are installed in the hicolor mimetype 
> theme). However for the gnome theme it seems to me that an icon from 
> a gnome/gtk package is better.
> 

I don't quite understand this. I said I will just follow your decision, and
please just tell me, what I should do? Thanks!


Spec URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee.spec
SRPM URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee-1.0.0-0.7.beta.src.rpm

About #13: I think the bug should always be assigned to some one, so the
contributor will not be confused so much. Nothing more. :p

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.