[Bug 225693] Merge Review: dialog

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: dialog


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225693


mildew at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mildew at gmail.com




------- Additional Comments From mildew at gmail.com  2007-02-25 16:12 EST -------
(!!) MUST: rpmlint output:
**** Review message:
W: dialog summary-ended-with-dot A utility for creating TTY dialog boxes.
W: dialog hardcoded-path-in-buildroot-tag /var/tmp/dialog-root
W: dialog buildprereq-use ncurses-devel, gettext

********************
(!!) MUST: Package must meet the Package Naming Guidelines
**** Review message:
- name: dialog-1.0.20060221-1
  should be: dialog-1.0-1.20060221svn
- Release tag should match format %{X}.%{alphatag} => 1.20060221svn
- Version tag should be 1.0

********************
(!!) MUST: The package must meet the Packaging Guidelines.
**** Review message:
- Package should not use the %makeinstall macro.
- Uses hardcoded buildroot, should be %{_tmppath}/%{name}-%{version}-%{release}-
root-%(%{__id_u} -n)

********************
(!!) MUST: All build depedencies must be listed in BuildRequires.
**** Review message:
- Package uses BuildPreReq instead of BuildRequires
********************


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.