[Bug 225645] Merge Review: cleanfeed

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cleanfeed


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225645





------- Additional Comments From rafalzaq at gmail.com  2007-02-25 17:51 EST -------
Needs work:
* Source 0 is not available
(ftp://ftp.exit109.com/users/jeremy/cleanfeed-0.95.7b.tar.gz)
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Spec file: some paths are not replaced with RPM macros
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Each %files section should have a %defattr line
  (wiki: Packaging/ReviewGuidelines)
* Some files (CHANGES & README) should be in %doc

rpmlint output:
Source RPM:
W: cleanfeed summary-ended-with-dot A spam filter for Usenet news servers.
W: cleanfeed invalid-license distributable
W: cleanfeed no-url-tag
E: cleanfeed hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/news/bin/filter
E: cleanfeed hardcoded-library-path in
$RPM_BUILD_ROOT/usr/lib/news/bin/filter/filter_innd.pl
E: cleanfeed hardcoded-library-path in /usr/lib/news/bin/filter
E: cleanfeed hardcoded-library-path in /usr/lib/news/bin/filter/filter_innd.pl
W: cleanfeed no-%build-section

rpmlint of cleanfeed:
W: cleanfeed summary-ended-with-dot A spam filter for Usenet news servers.
W: cleanfeed invalid-license distributable
W: cleanfeed no-url-tag
E: cleanfeed only-non-binary-in-usr-lib
W: cleanfeed conffile-without-noreplace-flag /etc/news/cleanfeed.conf
E: cleanfeed non-readable /usr/lib/news/bin/filter/filter_innd.pl 0750
E: cleanfeed non-standard-executable-perm
/usr/lib/news/bin/filter/filter_innd.pl 0750


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.