[Bug 225859] Merge Review: groff

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: groff


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225859


varekova at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |varekova at redhat.com




------- Additional Comments From varekova at redhat.com  2007-02-26 11:15 EST -------
- missing dist tag
- change the buildroot to recomanded:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- add %{?_smp_mflags}
- change defattr to (-,root,root,-)
- is the dependency on netpbm-progs necessary?
- is it possible to remove %makeinstall macro and use make install command?
- there should be used -p to preserve the timestamps


rpmlint output:
* srpm
W: groff summary-ended-with-dot A document formatting system.
E: groff tag-not-utf8 %changelog
E: groff non-utf8-spec-file groff.spec
W: groff prereq-use /sbin/install-info
W: groff unversioned-explicit-obsoletes groff-tools
W: groff unversioned-explicit-provides nroff-i18n
W: groff buildprereq-use byacc
E: groff hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/X11/app-defaults
W: groff mixed-use-of-spaces-and-tabs (spaces: line 145, tab: line 105)
W: groff patch-not-applied Patch14: groff-xlibs.patch
W: groff patch-not-applied Patch22: groff-1.18.1.1-bigendian.patch

*rpm
W: groff summary-ended-with-dot A document formatting system.
E: groff tag-not-utf8 %changelog
E: groff obsolete-not-provided groff-tools
E: groff only-non-binary-in-usr-lib
E: groff non-executable-script
/usr/share/groff/1.18.1.4/font/devps/generate/symbol.sed 0644
E: groff zero-length /usr/share/groff/1.18.1.4/tmac/mm/locale
E: groff non-executable-script
/usr/share/groff/1.18.1.4/font/devdvi/generate/CompileFonts 0644
E: groff non-executable-script /usr/lib/groff/groffer/version.sh 0644
E: groff zero-length /usr/share/groff/1.18.1.4/tmac/mm/se_locale
E: groff non-executable-script
/usr/share/groff/1.18.1.4/font/devps/generate/afmname 0644
E: groff-debuginfo tag-not-utf8 %changelog
W: groff-gxditview summary-ended-with-dot An X previewer for groff text
processor output.
E: groff-gxditview tag-not-utf8 %changelog
W: groff-gxditview no-documentation
W: groff-perl summary-ended-with-dot Parts of the groff formatting system that
require Perl.
E: groff-perl tag-not-utf8 %changelog


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.