[Bug 196837] Review Request: php-pear-PHPUnit - Regression testing framework for unit tests

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit - Regression testing framework for unit tests
Alias: pear-PHPUnit3

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196837





------- Additional Comments From Fedora at FamilleCollet.com  2007-02-27 13:16 EST -------
REVIEW
* source files match upstream:
fca4887ed95996a4b18e0cb0b8ff8130  PHPUnit-3.0.5.tgz* package meets naming and
packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible (BSD).
* latest version is being packaged (3.0.5)
* BuildRequires are proper.
* %clean is present.
* package builds in mock (FC6).
* package installs properly
* rpmlint is silent.
* final provides are sane:
php-pear(pear.phpunit.de/PHPUnit) = 3.0.5
php-pear-PHPUnit = 3.0.5-1.fc7
=> final Requires are sane:
see comment
* %check is not present; 
=> don't owns the directories it creates
* don't own directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Samples works well.

So MUST
- remove Conflicts (add Obsoletes)
- Requires: php-pear(PEAR) >= 1.5.0
- own %{pear_testdir}/%{pear_name}

Should 
- Remove (build safely, even in mock without)
# Need to allow installation in channel://pear.phpunit.de/
mkdir -p $RPM_BUILD_ROOT%{pear_phpdir}
cp -r %{pear_phpdir}/.channels $RPM_BUILD_ROOT%{pear_phpdir}/.channels

- simplify under doc (remove PHPUnit subdir)
%doc %{pear_name}-%{version}/docdir/%{pear_name}/%{pear_name}/*

- only uninstall old PHPunit on upgrade
%post
if [ $1 -gt  1 ] ; then
  ...
fi

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.