[Bug 222042] Review Request: GDAL - Geospatial Data Abstraction Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GDAL - Geospatial Data Abstraction Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222042





------- Additional Comments From cbalint at redhat.com  2007-02-27 19:37 EST -------
update:
Spec URL: http://openrisc.rdsor.ro/gdal.spec
SRPM URL: http://openrisc.rdsor.ro/gdal-1.4.0-8.src.rpm

 In an update please notice srpm that this as a complete repack of upstram 
gdal to a license safe fedora gdal source tarball. I explained every things 
in detail in PROVENANCE.TXT-fedora inside the tarball.
 Is this acceptable ? (we did so like this on xmms e.g)
 Is there a similar procedure for this kind of cases when need repack source?

(In reply to comment #45)
> Well, for -8:
> 
> * rpmlint
>   - some rpmlint complaint:
> -------------------------------------------------------
> E: gdal-debuginfo 
script-without-shebang /usr/src/debug/gdal-1.4.0/alg/gdal_tps.cpp
> W: gdal-debuginfo spurious-executable-perm
> /usr/src/debug/gdal-1.4.0/frmts/jpeg/gdalexif.h
> -------------------------------------------------------
>     perhaps permisson issue

fixed all.

> 
> * python scripts in %{_bindir}
>   - byte-compiled files are not needed and please %exclude them.
>     ("Unnecessary Byte compilation" section of
>       http://fedoraproject.org/wiki/Packaging/Python )

excluded.

> 
> * man files triage
>   - Please "triage" man files according to the corresponding binaries.
>     It seems that some man files should be installed in -python subpackage.

sorted out by their correct place.

> 
> * License
>   - LGPL codes seem to be included
> --------------------------------------------------------

> ./ogr/ogrsf_frmts/ili/iom/LICENSE.lgpl (and around this file)
this plugin is removed from source acording to -fedora tarball

> ./ogr/ogrsf_frmts/shape/LICENSE.LGPL  (and around this file)
^^^^ hmm, authors problem. If its still unacceptable i remove olso plugin.
please (overcomment)

> ./pymod/gdal2xyz.py (and around this file)
^^^ didnt see nothing. (please overcomment)

> ./pymod/samples/histrep.py 
^^^ didnt see nothing. (please overcomment)

> --------------------------------------------------------
>   - Note: not used for fedora package, however having different
>     license:
> --------------------------------------------------------
> ./swig/php/php_osr.h (and around this file) - PHP 2.02
> --------------------------------------------------------

removed whole php folder, acording to -fedora tarball

>    - Well, there are lots of "TO_RESOLVE" issues written on PROVENANCE.TXT.
>      We can leave as it is expecting that upstream would solve these 
issues??
>      Especially, the license of the files under ./data is unclear.
> 
> * ogdi
sorted out each piece and removed those in a new tarbal repack.

>   - As ogdi passed the review, would you enable ogdi again?

ogdi enabled.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.