[Bug 230324] Review Request: avrdude -Software for programming Atmel AVR Microcontroller

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avrdude -Software for programming Atmel AVR Microcontroller


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230324


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
               Flag|                            |fedora-review?




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-02-28 07:03 EST -------
MUST:
=====
0 rpmlint output is:
W: avrdude conffile-without-noreplace-flag /etc/avrdude.conf
W: avrdude-debuginfo spurious-executable-perm
/usr/src/debug/avrdude-5.3.1/safemode.c
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
0 Compiles and builds on devel x86_64
0 BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* no .desktop file required

MUST fix:
=========
* Doesn't compile, this can be fixed by removing "%{?_smp_mflags}" from the
  make command. Note that you can usually reproduce this problem yourself by
  adding "%_smp_mflags -j3" to ~/.rpmmacros . I have this even though I'm on a
  uni-processor machine.

* Missing BuildRequires: ncurses-devel readline-devel. Note that ncurses-devel
  is not really needed as readline-devel already Requires it.

* This rpmlint message:
  W: avrdude-debuginfo spurious-executable-perm
/usr/src/debug/avrdude-5.3.1/safemode.c
  Just chmod -x the file in %prep

Questions:
==========

* Can you explain a bit about how the config file is not supposed to be modified
  by end-users? Also can you add a comment to this extend above the %config line
  in the specfile?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.