[Bug 220967] Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-01 10:08 EST -------
Well,

(In reply to comment #7)
> (In reply to comment #6)
> > Unsure:
> > Does the -devel need ldconfig to be run?
> I believe the package guildline says it has to be done 
> for the package and its
> subpackage that contains a *.so.
It is not necessary. As when you try "ldconfig -v" and it returns like:
-------------------------------------------------
        libGL.so.1 -> libGL.so.1.2
-------------------------------------------------
ldconfig checks libraries with somajor if the library has 
somajor/sominor. and .so files are not (necessary to be) checked.

(In reply to comment #8)
> The scigraphica directory must belong to the 
> application and not the library.
Umm.. Ownership distribution between libraries <-> applications is
of second importance or less.

First of all, "all directories created during installation must
belong to some package". You can install libscigraphica without
any applications which may use this library. %{_libdir}/scigraphica/
_must_ be owned by this package.

There are other issues.
----------------------------------
/usr/share/aclocal/libscigraphica-2.0.m4
----------------------------------
This should be in -devel package and owning aclocal m4 files means
-devel package should need "Requires: automake"

libscigraphica-2.0.pc says:
-----------------------------------
Requires: glib-2.0 gtk+-2.0 gtkextra-2.0
-----------------------------------
This means that -devel package should require ????-devel 
as well as pkgconfig (Please check "Requires" section of
http://fedoraproject.org/wiki/Packaging/Guidelines)

And.. this package contains many documentations (xml/header files,
etc) and image files and keeping timestamps on these files 
are strongly recommended. Please keep timestamps on these files.
(I have not tried, however for many cases
-----------------------------------------------------
make DESTDIR=%{buildroot} INSTALL="%{__install} -c -p" install
------------------------------------------------------
works.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.