[Bug 215241] Review Request: thunar-archive-plugin - Archive plugin for the Thunar file manager

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 2 21:51:30 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: thunar-archive-plugin - Archive plugin for the Thunar file manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215241


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From pertusus at free.fr  2007-01-02 16:51 EST -------
* rpmlint is silent
X license seems to be LGPL, license included but is GPL in specfile
* follow guidelines
* match upstream
a164326a32a64063079405da11677f0a  thunar-archive-plugin-0.2.2.tar.bz2
* sane provides, with the usual bogus dlopened module useless soname:
Provides: thunar-archive-plugin.so
* own directories, /usr/lib/thunarx-1/ should be owned by thunar
* build and works correctly out of the box
* BuildRequires and Requires seem to be right

It is not obvious that the gtk cache update is needed, but I guess it
is needed for the icons in the right-click thunar menu?

The scriptlet snippet isn't the same than in the guidelines but the 
one proposed here should be right, too.


The only real issue pending is the License issue. This is APPROVED if you
fix it, no need to repost a srpm if it is the only difference.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list