[Bug 221108] Review Request: openarena - first person shooter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openarena - first person shooter
Alias: openarena

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221108


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris.stone at gmail.com  2007-01-03 16:11 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output:
W: openarena-data no-documentation

permissible although I usually suggest atleast placing the license file in the
sub-package.

- package named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- licensed with open source compatible license
- license field matches actual license
- license file included in %doc
- spec file written in American english
- spec file legible

although I would suggest a little extra whitespace in a couple places to make
parsing the spec file easier.

- sources match upstream
0c2c27456a11331d61448278a1e9aaad  /home/chris/oa060.tar.gz
- package successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries stored in ldconfig default path
- package is not relocatable
- package owns all directories it creates
- directories it does not create owned by default packages
- no duplicates listed in %files
- file permissions set properly
- package contains proper %clean section
- macro usage consistent
- package contains code
- no large documentation files
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffix
- no need for devel subpackage
- no .la files
- package contains proper .desktop file
- package does not own files or directories owned by other packages


*** APPROVED ***


==== SHOULD FIX ====
- add %doc doc/COPYING to data subpackage
- remove LINUXNOTES from %doc


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.