[Bug 218556] Review Request: ecryptfs-utils - Linux eCryptfs utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ecryptfs-utils - Linux eCryptfs utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218556





------- Additional Comments From kevin at tummy.com  2007-01-03 22:58 EST -------
Hey Michael.

First one general query: You are upstream for this package, do you intend to
only maintain this one package in fedora, or are you planning on submitting
more. If you are just seeking to make sure this is in fedora, perhaps someone
who is already a maintainer might step up to do so. This would save you having
to go through the sponsorship process and also take a task off your hands if you
don't want to do it. ;) 

If you do have additional packages you want to maintain, you might submit 
them as well. Multiple submissions and/or adding review comments to other 
packages helps sponsors see that you know the guidelines and are ready to 
be sponsored. 

That said, here are some general comments/suggestions on this package: 

- You might use the %{?dist} tag. This is very handy when you push the same
version of a package to multiple releases, so upgrades are still smooth. 
http://fedoraproject.org/wiki/Packaging/DistTag

- Build on x86_64 doesn't work. The build process ends with: 
RPM build errors:
    File not found:
/var/tmp/ecryptfs-utils-8-1.fc7-root-mockbuild/usr/lib64/ecryptfs

It looks like the package is installing /usr/lib/ecryptfs on x86_64, when
it should be installing in /usr/lib64/ecryptfs.

If you need a x86_64 test machine, I have one handy and would be happy 
to provide you an account on it. 

- When going through a review, do add a changelog entry to your spec file and 
increment the version for each change. That helps reviewers see that items 
were addressed and when. There shouldn't be a need to increase the version 
upstream unless there were changes to the upstream package. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.