[Bug 221308] Review Request: python-twisted-mail - A Twisted Mail library, server and client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-mail - A Twisted Mail library, server and client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221308


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2007-01-03 23:45 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (MIT)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream sha1sum/md5sum:
56f65ebb7c35a6efcaf4983af7e015dfb7ab9eac  TwistedMail-0.3.0.tar.bz2
56f65ebb7c35a6efcaf4983af7e015dfb7ab9eac  TwistedMail-0.3.0.tar.bz2.1
33667938b399ee5513c59b5d4087294b  TwistedMail-0.3.0.tar.bz2
33667938b399ee5513c59b5d4087294b  TwistedMail-0.3.0.tar.bz2.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs (i386/x86_64)
OK - Should have dist tag
OK - Should package latest version

Issues:

1. rpmlint says:

E: python-twisted-mail no-binary
(which can be ignored. This package has to be arch since the
entire twisted stack must be due to python-twisted core being so).

I don't see any blockers here... this package is APPROVED.
Don't forget to close this NEXTRELEASE once it's been imported
and built.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.