[Bug 221405] Review Request: libdirac - Dirac is an open source video codec

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 4 18:25:13 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libdirac - Dirac is an open source video codec


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221405





------- Additional Comments From rc040203 at freenet.de  2007-01-04 13:25 EST -------
Some initial remarks:

- Don't build the static libs (Append --disable-static to %configure).

- Don't run the autotools as part of building. Autotool-generated files should
  be part of the source code. (Running the autotools as part of building 
  exposes a package to subtile incompatiblities between different versions 
  of the autotools. In fact, this package really suffers from some (however
  minor) issues).

- The package doesn't honour RPM_OPT_FLAGS correctly: It plays dirty games 
  on CFLAGS/CXXFLAGS (E.g. it must not append -O3 and -mmx).

- The *-devel subpackage ships a *.pc. Therefore it must 
Requires: pkgconfig

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list